-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Comparing changes
Open a pull request
base repository: videojs/video.js
base: v8.16.1
head repository: videojs/video.js
compare: main
- 12 commits
- 20 files changed
- 9 contributors
Commits on Jun 25, 2024
-
fix: apply correct styles to audio descriptions track menu items (#8770)
Configuration menu - View commit details
-
Copy full SHA for f701102 - Browse repository at this point
Copy the full SHA f701102View commit details
Commits on Jul 6, 2024
-
feat: Adds a transient button component (#8629)
## Description Adds a `TransientButton` component for the types of button that are shown on top of the video briefly during playback and reappear when there is user activity. e.g. Unmute buttons, skip intro. It aims is to be a generic button type to be extended. Some basic styles are provided but kept light to not complicate customisation. It's important to insert a transient button before the control bar for the tab order to make sense. _Optionally_ takes focus when shown. ## Specific Changes proposed Adds `TransientButton` component. ## Requirements Checklist - [x] Feature implemented / Bug fixed - [ ] If necessary, more likely in a feature request than a bug fix - [x] Change has been verified in an actual browser (Chrome, Firefox, IE) - [x] Unit Tests updated or fixed - [ ] Docs/guides updated - [x] Example: https://deploy-preview-8629--videojs-preview.netlify.app/sandbox/transient-button.html - [x] Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab) - [x] Has no changes to JSDoc which cause `npm run docs:api` to error - [ ] Reviewed by Two Core Contributors
Configuration menu - View commit details
-
Copy full SHA for 1afe504 - Browse repository at this point
Copy the full SHA 1afe504View commit details -
fix(middleware): cache grows even if no middleware created (#8674)
## Description See issue #8653 ## Specific Changes proposed When in `middleware.js` the function `clearCacheForPlayer` runs, before setting a value to null in middlware caches, it checks if the key exists in the first place. ## Requirements Checklist - [x] Feature implemented / Bug fixed - [x] If necessary, more likely in a feature request than a bug fix - [x] Change has been verified in an actual browser (Chrome, Firefox, IE) - [ ] Unit Tests updated or fixed - [ ] Docs/guides updated - [x] Example created ([starter template on JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0)) - [ ] Reviewed by Two Core Contributors --------- Co-authored-by: Giuseppe Piscopo <g.piscopo@braincrumbz.com> Co-authored-by: mister-ben <git@misterben.me>
Configuration menu - View commit details
-
Copy full SHA for 6221a8f - Browse repository at this point
Copy the full SHA 6221a8fView commit details -
fix(types): fix and improve component ready callback definition (#8766)
- Removes erroneous `@return {Component}` from `ReadyCallback` in Component - Remove `@this {Component}` from `ReadyCallback` in Component, because this is not accurate for classes that extend Component - Adds `@returns {void}` to `ReadyCallback` in Component - Produces a more accurate typedef - Isn't strictly accurate in jsdoc/javascript but does this matter since it's well understood. Absence of `@return` is interpreted by tsc as returning `{any}`, `@returns {undefined}` would require an explicit `return undefined` in ts. - Adds a `{PlayerReadyCallback}` in Player with `@this {Player}` used in the `new Player()` and `videos()` constructors. - Are we ok adding this new typedef - Is inconsistent with `player.ready()` which uses `ReadyCallback` without `@this` - but this can't be changed without adding an otherwise unnecessary override just to pander to tsc. ## Requirements Checklist - [x] Feature implemented / Bug fixed - [ ] If necessary, more likely in a feature request than a bug fix - [x] Change has been verified in an actual browser (Chrome, Firefox, IE) - [ ] Unit Tests updated or fixed - [ ] Docs/guides updated - [ ] Example created ([starter template on JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0)) - [x] Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab) - [x] Has no changes to JSDoc which cause `npm run docs:api` to error - [ ] Reviewed by Two Core Contributors
Configuration menu - View commit details
-
Copy full SHA for 970faa8 - Browse repository at this point
Copy the full SHA 970faa8View commit details
Commits on Jul 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 51b4670 - Browse repository at this point
Copy the full SHA 51b4670View commit details
Commits on Jul 14, 2024
-
fix: ensure transient button event listeners are removed on dispose (#…
…8796) ## Description Transient button sets an event listener on the player directly instead of on itself, which doesn't get cleaned up when disposed. Fixes #8795 ## Specific Changes proposed Call `on` on the component with player as the first arg, instead of calling `on` on the player directly. ## Requirements Checklist - [x] Feature implemented / Bug fixed - [ ] If necessary, more likely in a feature request than a bug fix - [x] Change has been verified in an actual browser (Chrome, Firefox, IE) - [ ] Unit Tests updated or fixed - [ ] Docs/guides updated - [ ] Example created ([starter template on JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0)) - [x] Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab) - [x] Has no changes to JSDoc which cause `npm run docs:api` to error - [ ] Reviewed by Two Core Contributors
Configuration menu - View commit details
-
Copy full SHA for 0a836e1 - Browse repository at this point
Copy the full SHA 0a836e1View commit details
Commits on Jul 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e78bcc7 - Browse repository at this point
Copy the full SHA e78bcc7View commit details
Commits on Jul 22, 2024
-
chore: update vhs version 3.13.2 (#8812)
## Description Update vhs version (v3.13.2) ## Specific Changes proposed Please list the specific changes involved in this pull request. ## Requirements Checklist - [ ] Feature implemented / Bug fixed - [ ] If necessary, more likely in a feature request than a bug fix - [ ] Change has been verified in an actual browser (Chrome, Firefox, IE) - [ ] Unit Tests updated or fixed - [ ] Docs/guides updated - [ ] Example created ([starter template on JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0)) - [ ] Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab) - [ ] Has no changes to JSDoc which cause `npm run docs:api` to error - [ ] Reviewed by Two Core Contributors Co-authored-by: Dzianis Dashkevich <ddashkevich@brightcove.com>
Configuration menu - View commit details
-
Copy full SHA for 49151ee - Browse repository at this point
Copy the full SHA 49151eeView commit details -
Dzianis Dashkevich committed
Jul 22, 2024 Configuration menu - View commit details
-
Copy full SHA for 798647b - Browse repository at this point
Copy the full SHA 798647bView commit details -
fix: Refactor evented to make mincompatable with Chrome 53 (#8810)
## Description Chrome 53 doesn't like the minified output. Specifically, it throws `Uncaught SyntaxError: Unexpected token (` on the ternary in the minified version of `normalizeListenArgs()` https://github.com/videojs/video.js/blob/e78bcc7b2d829fce01451cf105b918d8feec4548/src/js/mixins/evented.js#L165-L195 Line breaks added for clarify ```js Tt = (e, t, s) => { var i = t.length < 3 || t[0] === e || t[0] === e.eventBusEl_; let r, n, a; return i ? (r = e.eventBusEl_, 3 <= t.length && t.shift(), [n, a] = t) : [r, n, a] = t, ft(r, e, s), yt(n, e, s), bt(a, e, s), a = _(e, a), { isTargetingSelf: I, target: r, type: n, listener: a } }, ``` Chrome would be happy with this if `[r, n, a] = t` were `([r, n, a] = t)`. ## Specific Changes proposed Refactor `normalizeListenArgs()` slightly to use multiple statements to coerce uglify-js to include parentheses. Also updates uglify-js, but that in itself isn't the fix. Fixes #8783 ## Requirements Checklist - [x] Feature implemented / Bug fixed - [ ] If necessary, more likely in a feature request than a bug fix - [x] Change has been verified in an actual browser - Browserstack Chrome 53 - [ ] Unit Tests updated or fixed - [ ] Docs/guides updated - [ ] Example created ([starter template on JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0)) - [x] Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab) - [x] Has no changes to JSDoc which cause `npm run docs:api` to error - [ ] Reviewed by Two Core Contributors --------- Co-authored-by: Gary Katsevman <git@gkatsev.com>
Configuration menu - View commit details
-
Copy full SHA for a7c9f26 - Browse repository at this point
Copy the full SHA a7c9f26View commit details -
fix: Listen to taps on track controls (#8809)
## Description The refactored text track controls aren't listening for tap events. ## Specific Changes proposed Add tap handler to done and reset buttons. Fixes #8808 ## Requirements Checklist - [x] Feature implemented / Bug fixed - [ ] If necessary, more likely in a feature request than a bug fix - [x] Change has been verified in an actual browser (Chrome, Firefox, IE) - [ ] Unit Tests updated or fixed - [ ] Docs/guides updated - [ ] Example created ([starter template on JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0)) - [x] Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab) - [x] Has no changes to JSDoc which cause `npm run docs:api` to error - [ ] Reviewed by Two Core Contributors
Configuration menu - View commit details
-
Copy full SHA for 86d29cd - Browse repository at this point
Copy the full SHA 86d29cdView commit details -
fix(spatial-navigation): keep navigation going when player has an err…
…or (#8805) ## Description The bug: Focus is lost when playback error is displayed. This small PR will update the spatial-navigation logic so when the error modal is shown the spatial-navigation will try to focus the components present in the error modal, in most cases this will be the vjs close button. ## Specific Changes proposed Keep navigation working when player shows the error modal by focusing a component in that modal. ## Requirements Checklist - [x] Feature implemented / Bug fixed - [ ] If necessary, more likely in a feature request than a bug fix - [ ] Change has been verified in an actual browser (Chrome, Firefox, IE) - [ ] Unit Tests updated or fixed - [ ] Docs/guides updated - [ ] Example created ([starter template on JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0)) - [ ] Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab) - [ ] Has no changes to JSDoc which cause `npm run docs:api` to error - [ ] Reviewed by Two Core Contributors
Configuration menu - View commit details
-
Copy full SHA for 76e99b7 - Browse repository at this point
Copy the full SHA 76e99b7View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v8.16.1...main